Add more features flags and default values to system_settings.py
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I figured since [Sal's 'Settings' wiki page](https://github.com/salopensource/sal/wiki/Settings) states the following... ``` There are defaults set in sal/system_settings.py, but they can be overridden if you choose ``` ... that it might be a good idea to enumerate most every toggle-able feature within the `server_settings.py` file. That said... This PR suggests the following changes to `sal/sal/system_settings.py`: - Add comment explanation (pulled from the wiki page) above `EXCLUDED_FACTS` definition - Add `IGNORE_FACTS` setting with default value of `[]` - Add `ADD_TO_ALL_BUSINESS_UNITS` with default value of `False` - Add `ADD_NEW_MACHINES` with default value of `True`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Sal's 'Settings' wiki page states the following...
... I figured that it might be a good idea to enumerate most every toggle-able feature within the
server_settings.pyfile. That said...This PR suggests the following changes to
sal/sal/system_settings.py:EXCLUDED_FACTSdefinitionIGNORE_FACTSsetting with default value of[]ADD_TO_ALL_BUSINESS_UNITSwith default value ofFalseADD_NEW_MACHINESwith default value ofTrue